You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Johan Corveleyn <jc...@gmail.com> on 2010/11/17 02:14:20 UTC
[PATCH] copy_tests.py - expand move_file_back_and_forth, to verify
issue #3429
The attached patch expands the test "move_file_back_and_forth"
(copy_tests.py 45) as a regression test for issue#3429.
[[[
Expand move_file_back_and_forth test to verify issue #3429
("svn mv A B; svn mv B A" generates replace without history).
* subversion/tests/cmdline/copy_tests.py
(move_file_back_and_forth): Check expected status before commit.
]]]
Cheers,
--
Johan
Re: [PATCH] copy_tests.py - expand move_file_back_and_forth, to
verify issue #3429
Posted by Johan Corveleyn <jc...@gmail.com>.
On Wed, Dec 8, 2010 at 3:17 PM, Julian Foad <ju...@wandisco.com> wrote:
> On Wed, 2010-11-17, Johan Corveleyn wrote:
>> On Wed, Nov 17, 2010 at 2:14 AM, Johan Corveleyn <jc...@gmail.com> wrote:
>> > The attached patch expands the test "move_file_back_and_forth"
>> > (copy_tests.py 45) as a regression test for issue#3429.
> [...]
>> I just realized that I can add a similar check to
>> move_dir_back_and_forth. Here is a second patch that expands both
>> tests.
>
> Thank you, Johan. Committed revision 1043427. (I tweaked the comments
> a bit.)
>
> I have closed issue #3429.
Thanks!
>> (note: can the "if svntest.main.wc_is_singledb(wc_dir)" be dropped
>> from move_dir_back_and_forth?)
>
> Because single-db is now always enabled? Yes. But it's sometimes nice
> to be able to go back and test older code with the current tests, so
> let's not hurry to remove it.
Ok, got it.
Cheers,
--
Johan
Re: [PATCH] copy_tests.py - expand move_file_back_and_forth, to
verify issue #3429
Posted by Julian Foad <ju...@wandisco.com>.
On Wed, 2010-11-17, Johan Corveleyn wrote:
> On Wed, Nov 17, 2010 at 2:14 AM, Johan Corveleyn <jc...@gmail.com> wrote:
> > The attached patch expands the test "move_file_back_and_forth"
> > (copy_tests.py 45) as a regression test for issue#3429.
[...]
> I just realized that I can add a similar check to
> move_dir_back_and_forth. Here is a second patch that expands both
> tests.
Thank you, Johan. Committed revision 1043427. (I tweaked the comments
a bit.)
I have closed issue #3429.
> (note: can the "if svntest.main.wc_is_singledb(wc_dir)" be dropped
> from move_dir_back_and_forth?)
Because single-db is now always enabled? Yes. But it's sometimes nice
to be able to go back and test older code with the current tests, so
let's not hurry to remove it.
- Julian
> Log message:
> [[[
> Expand move_file_back_and_forth and move_dir_back_and_forth tests to verify
> issue #3429 ("svn mv A B; svn mv B A" generates replace without history).
>
> * subversion/tests/cmdline/copy_tests.py
> (move_file_back_and_forth): Check expected status before commit.
> (move_dir_back_and_forth): Check expected status after executing the moves.
> ]]]
Re: [PATCH] copy_tests.py - expand move_file_back_and_forth, to
verify issue #3429
Posted by Johan Corveleyn <jc...@gmail.com>.
On Wed, Nov 17, 2010 at 2:14 AM, Johan Corveleyn <jc...@gmail.com> wrote:
> The attached patch expands the test "move_file_back_and_forth"
> (copy_tests.py 45) as a regression test for issue#3429.
>
> [[[
> Expand move_file_back_and_forth test to verify issue #3429
> ("svn mv A B; svn mv B A" generates replace without history).
>
> * subversion/tests/cmdline/copy_tests.py
> (move_file_back_and_forth): Check expected status before commit.
> ]]]
I just realized that I can add a similar check to
move_dir_back_and_forth. Here is a second patch that expands both
tests.
(note: can the "if svntest.main.wc_is_singledb(wc_dir)" be dropped
from move_dir_back_and_forth?)
Log message:
[[[
Expand move_file_back_and_forth and move_dir_back_and_forth tests to verify
issue #3429 ("svn mv A B; svn mv B A" generates replace without history).
* subversion/tests/cmdline/copy_tests.py
(move_file_back_and_forth): Check expected status before commit.
(move_dir_back_and_forth): Check expected status after executing the moves.
]]]
Cheers,
--
Johan
Re: [PATCH] copy_tests.py - expand move_file_back_and_forth, to
verify issue #3429
Posted by Johan Corveleyn <jc...@gmail.com>.
On Wed, Nov 17, 2010 at 2:14 AM, Johan Corveleyn <jc...@gmail.com> wrote:
> The attached patch expands the test "move_file_back_and_forth"
> (copy_tests.py 45) as a regression test for issue#3429.
>
> [[[
> Expand move_file_back_and_forth test to verify issue #3429
> ("svn mv A B; svn mv B A" generates replace without history).
>
> * subversion/tests/cmdline/copy_tests.py
> �(move_file_back_and_forth): Check expected status before commit.
> ]]]
I just realized that I can add a similar check to
move_dir_back_and_forth. Here is a second patch that expands both
tests.
(note: can the "if svntest.main.wc_is_singledb(wc_dir)" be dropped
from move_dir_back_and_forth?)
Log message:
[[[
Expand move_file_back_and_forth and move_dir_back_and_forth tests to verify
issue #3429 ("svn mv A B; svn mv B A" generates replace without history).
* subversion/tests/cmdline/copy_tests.py
(move_file_back_and_forth): Check expected status before commit.
(move_dir_back_and_forth): Check expected status after executing the moves.
]]]
Cheers,
--
Johan