You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/04/24 23:39:00 UTC
[jira] [Commented] (SENTRY-2212) smart-apply-patch.sh isn't so
smart, won't apply changes when files have been moved or renamed
[ https://issues.apache.org/jira/browse/SENTRY-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451411#comment-16451411 ]
Hadoop QA commented on SENTRY-2212:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12920523/SENTRY-2212-001.patch against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3742/console
This message is automatically generated.
> smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed
> ----------------------------------------------------------------------------------------------
>
> Key: SENTRY-2212
> URL: https://issues.apache.org/jira/browse/SENTRY-2212
> Project: Sentry
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.1.0
> Reporter: Steve Moist
> Assignee: Steve Moist
> Priority: Major
> Fix For: 2.1.0
>
> Attachments: SENTRY-2212-001.patch
>
>
> When applying changes of moving the files across modules, smart-apply-patch.sh doesn't pick up the move so it leaves them in place and makes changes on top of the old files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)