You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Claude Warren (Jira)" <ji...@apache.org> on 2022/09/01 05:34:00 UTC

[jira] [Comment Edited] (CASSANDRA-8612) Read metrics should be updated on all types of reads

    [ https://issues.apache.org/jira/browse/CASSANDRA-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598285#comment-17598285 ] 

Claude Warren edited comment on CASSANDRA-8612 at 9/1/22 5:33 AM:
------------------------------------------------------------------

[~cnlwsu] I created a pull request [https://github.com/apache/cassandra/pull/1827|https://github.com/apache/cassandra/pull/1827] to merge the fix for this into trunk.  Please review.


was (Author: claudenw):
[~cnlwsu] I created a pull request [https://github.com/apache/cassandra/pull/1827|https://github.com/apache/cassandra/pull/1827)] to merge the fix for this into trunk.  Please review.

> Read metrics should be updated on all types of reads
> ----------------------------------------------------
>
>                 Key: CASSANDRA-8612
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8612
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Metrics
>            Reporter: Chris Lohfink
>            Assignee: Dean Z
>            Priority: Low
>              Labels: lhf, metrics
>         Attachments: 0001-Update-read-metrics-on-all-types-of-reads.patch, 0002-Add-more-read-metrics-into-PartitionRangeReadCommand.patch
>
>
> Metrics like "sstables per read" are not updated on a range slice.  Although separating things out for each type of read could make sense like we do for latencies, only exposing the metrics for one type can be a little confusing when people do a query and see nothing increases.  I think its sufficient to use the same metrics for all reads.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org