You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Stipe Tolj <to...@wapme-systems.de> on 2002/05/31 11:20:07 UTC

[PATCH] 1.3: Cygwin specifics in http_main.c

Attached is a patch for allowing user changes on the cygwin platform
and a #define wrapper for the timeout singal we use to kill of pending
open childs that do not react on "usual" signals.

The signalling issue seems to be a problem on the Cygwin platform, but
it's abstracted, so other platforms may benefit from it. Again,
nothing else is changed in behaviour.

Changes are:

  * src/include/ap_config.h: added the system uid for Cygwin that is
the "root" user on Cygwin

  * src/main/http_main.c: some cygwin specific #defines around
setpgrp() and getuid() calls. Adding the #define SIG_TIMEOUT_KILL to
define which singal should be used to kill of timed out childs.
Defaulting to the know value for all other plaforms.

  * src/modules/proxy/proxy_cache.c: cygwin specific #define around
setpgrp()


Please review and apply to cvs if suitable. Thanks in advance.

Stipe

tolj@wapme-systems.de
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: info@wapme-systems.de
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are

Re: [PATCH] 1.3: Cygwin specifics in http_main.c

Posted by Stipe Tolj <to...@wapme-systems.de>.
Jim Jagielski wr0te:
> 
> This looks safe to me... I'll give it a day or so for any vetos
> to pop up, but if they don't I'll committ

thanks Jim.

Stipe

-- Hope to see you at my presentations:

   "Virtual Server solution for Linux using FreeVSD" 
   at O'Reilly Open Source Convention 2002,
   Sheraton San Diego Hotel and Marina, San Diego, CA. USA
   July 22-26, 2002 

tolj@wapme-systems.de
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: info@wapme-systems.de
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are

Re: [PATCH] 1.3: Cygwin specifics in http_main.c

Posted by Jim Jagielski <ji...@jaguNET.com>.
At 11:20 AM +0200 5/31/02, Stipe Tolj wrote:
>Attached is a patch for allowing user changes on the cygwin platform
>and a #define wrapper for the timeout singal we use to kill of pending
>open childs that do not react on "usual" signals.
>
>The signalling issue seems to be a problem on the Cygwin platform, but
>it's abstracted, so other platforms may benefit from it. Again,
>nothing else is changed in behaviour.
>
>Changes are:
>
>  * src/include/ap_config.h: added the system uid for Cygwin that is
>the "root" user on Cygwin
>
>  * src/main/http_main.c: some cygwin specific #defines around
>setpgrp() and getuid() calls. Adding the #define SIG_TIMEOUT_KILL to
>define which singal should be used to kill of timed out childs.
>Defaulting to the know value for all other plaforms.
>
>  * src/modules/proxy/proxy_cache.c: cygwin specific #define around
>setpgrp()
>
>Please review and apply to cvs if suitable. Thanks in advance.
>

This looks safe to me... I'll give it a day or so for any vetos
to pop up, but if they don't I'll committ
-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
      "A society that will trade a little liberty for a little order
             will lose both and deserve neither" - T.Jefferson