[GitHub] [incubator-druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #6974: sql support for dynamic parameters
URL: https://github.com/apache/incubator-druid/pull/6974#discussion_r309806597
 
 

 ##########
 File path: extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/sql/FixedBucketsHistogramQuantileSqlAggregatorTest.java
 ##########
 @@ -206,7 +206,12 @@ public void testQuantileOnFloatAndLongs() throws Exception
                        + "FROM foo";
 
     // Verify results
-    final List<Object[]> results = sqlLifecycle.runSimple(sql, QUERY_CONTEXT_DEFAULT, authenticationResult).toList();
+    final List<Object[]> results = sqlLifecycle.runSimple(
+        sql,
+        QUERY_CONTEXT_DEFAULT,
+        ImmutableList.of(),
 
 Review comment:
   Adding a named constant (e.g., `NO_PARAMETERS`) may be useful here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org