[GitHub] [james-project] jeantil commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering

[GitBox <gi...@apache.org>]

jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526184190



##########
File path: server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##########
@@ -17,19 +17,17 @@
     specific language governing permissions and limitations
     under the License.
 -->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

Review comment:
       it's not mandatory but because whitespace is considered non-significant in the XML specification parsers don't keep position information in many cases this is one of them. Since
   - there were few pom affected by the whitespace removal 
   - this will prevent spurious modifications that humans will have to think about
   - the namespace declaration on the project tag are more or less noise to humans
   I added the few normalizations to the PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org