You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/10 16:30:00 UTC

[jira] [Work logged] (GOBBLIN-1111) CsvToJsonConverterV2 should not log raw data

     [ https://issues.apache.org/jira/browse/GOBBLIN-1111?focusedWorklogId=420305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420305 ]

ASF GitHub Bot logged work on GOBBLIN-1111:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/20 16:29
            Start Date: 10/Apr/20 16:29
    Worklog Time Spent: 10m 
      Work Description: haojiliu commented on pull request #2953: [GOBBLIN-1111] CsvToJsonConverterV2 should not print raw data in log
URL: https://github.com/apache/incubator-gobblin/pull/2953
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1111
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   raw data might contain PII information. During testing, user sensitive data will be collected and stored in the logs. This is a data privacy risk, and is also polluting the log as we are printing out every single line of record read in.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   No testing as it's code deletion. Build succeeded.
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 420305)
    Remaining Estimate: 0h
            Time Spent: 10m

> CsvToJsonConverterV2 should not log raw data
> --------------------------------------------
>
>                 Key: GOBBLIN-1111
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1111
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-core
>            Reporter: Haoji Liu
>            Assignee: Abhishek Tiwari
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> raw data might contain PII information. The current usage of gobblin I'm seeing when during testing, that we always log on the debug level. And user sensitive data will be collected and stored in your logs. This is a data privacy risk as PII data should not be stored and accessible to all the developers.
> This is also polluting the log as we are printing out every single line of record read in.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)