You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Jake Maes <ja...@gmail.com> on 2015/10/02 23:29:04 UTC

Review Request 38966: SAMZA-786: Improve reliability of multithreaded host affinity tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38966/
-----------------------------------------------------------

Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure).


Repository: samza


Description
-------

Replace most of the sleeps with a wait()-->notifyAll() solution and 
> remove the allocator thread from a couple tests where it isn't needed.


Diffs
-----

  samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java b5e0368d43c87e44ac36f6b6a32f51d0c39a2ec7 
  samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java 0d07e284276be95e5996783767f850643b294572 
  samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java ee4a5b03329fa6eab9f6ecce09a427ebd09eb7db 
  samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerListener.java PRE-CREATION 
  samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerRequestState.java PRE-CREATION 

Diff: https://reviews.apache.org/r/38966/diff/


Testing
-------

./gradlew clean samza-yarn:test


Thanks,

Jake Maes


Re: Review Request 38966: SAMZA-786: Improve reliability of multithreaded host affinity tests.

Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38966/#review101720
-----------------------------------------------------------

Ship it!


Ship It!

- Yi Pan (Data Infrastructure)


On Oct. 2, 2015, 9:29 p.m., Jake Maes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38966/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 9:29 p.m.)
> 
> 
> Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Replace most of the sleeps with a wait()-->notifyAll() solution and 
> > remove the allocator thread from a couple tests where it isn't needed.
> 
> 
> Diffs
> -----
> 
>   samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java b5e0368d43c87e44ac36f6b6a32f51d0c39a2ec7 
>   samza-yarn/src/test/java/org/apache/samza/job/yarn/TestContainerAllocator.java 0d07e284276be95e5996783767f850643b294572 
>   samza-yarn/src/test/java/org/apache/samza/job/yarn/TestHostAwareContainerAllocator.java ee4a5b03329fa6eab9f6ecce09a427ebd09eb7db 
>   samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerListener.java PRE-CREATION 
>   samza-yarn/src/test/java/org/apache/samza/job/yarn/util/MockContainerRequestState.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38966/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean samza-yarn:test
> 
> 
> Thanks,
> 
> Jake Maes
> 
>