You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by davies <gi...@git.apache.org> on 2014/10/15 02:17:21 UTC

[GitHub] spark pull request: [SPARK-3952] add Python examples in Streaming ...

GitHub user davies opened a pull request:

    https://github.com/apache/spark/pull/2808

    [SPARK-3952] add Python examples in Streaming Programming Guide

    Having Python examples in Streaming Programming Guide.
    
    Also add RecoverableNetworkWordCount example.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davies/spark pyguide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2808
    
----
commit 7e4bb8a098236bf9fa2e86e22935a45c04c5edd3
Author: Davies Liu <da...@gmail.com>
Date:   2014-10-15T00:08:50Z

    add Python examples in Streaming Programming Guide

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2808#discussion_r18999382
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -398,6 +498,30 @@ JavaSparkContext sc = ...   //existing JavaSparkContext
     JavaStreamingContext ssc = new JavaStreamingContext(sc, new Duration(1000));
     {% endhighlight %} 
     </div>
    +<div data-lang="python" markdown="1">
    +
    +A [StreamingContext](api/python/pyspark.streaming.html#pyspark.streaming.StreamingContext) object can be created from a [SparkContext](api/python/pyspark.html#pyspark.SparkContext) object.
    --- End diff --
    
    It looks like the PySpark streaming docs aren't being included in Sphinx because this first link didn't work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59550837
  
    It looks like there's a missing tag or space or something, because now the markup after the connection pool section is messed up:
    
    ![image](https://cloud.githubusercontent.com/assets/50748/4683485/f8e7913a-5626-11e4-91da-900f8fa1dd45.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59146061
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21756/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59635202
  
      [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21879/consoleFull) for   PR 2808 at commit [`8d4bec4`](https://github.com/apache/spark/commit/8d4bec4a5076bcc878498a404e435c0064289d3e).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2808#discussion_r18999451
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -398,6 +498,30 @@ JavaSparkContext sc = ...   //existing JavaSparkContext
     JavaStreamingContext ssc = new JavaStreamingContext(sc, new Duration(1000));
     {% endhighlight %} 
     </div>
    +<div data-lang="python" markdown="1">
    +
    +A [StreamingContext](api/python/pyspark.streaming.html#pyspark.streaming.StreamingContext) object can be created from a [SparkContext](api/python/pyspark.html#pyspark.SparkContext) object.
    --- End diff --
    
    Upon closer inspection, it looks like we don't have a `pyspark.streaming.rst` file in the `python/docs` folder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2808#discussion_r19001885
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -398,6 +498,30 @@ JavaSparkContext sc = ...   //existing JavaSparkContext
     JavaStreamingContext ssc = new JavaStreamingContext(sc, new Duration(1000));
     {% endhighlight %} 
     </div>
    +<div data-lang="python" markdown="1">
    +
    +A [StreamingContext](api/python/pyspark.streaming.html#pyspark.streaming.StreamingContext) object can be created from a [SparkContext](api/python/pyspark.html#pyspark.SparkContext) object.
    --- End diff --
    
    I forget to include that in previous PR, will add it in this PR, sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59460636
  
    This looks good to me.  I tried running the examples and they worked as expected.  I left a couple of minor comments, but besides those I think this is ready for merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59600543
  
      [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/397/consoleFull) for   PR 2808 at commit [`26a7e37`](https://github.com/apache/spark/commit/26a7e379f6135a51478552bfd7c85af449c4bb69).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59146058
  
      [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21756/consoleFull) for   PR 2808 at commit [`7e4bb8a`](https://github.com/apache/spark/commit/7e4bb8a098236bf9fa2e86e22935a45c04c5edd3).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59469000
  
    @JoshRosen  I had addressed your comments, also added code tabs for design patterns section.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/2808


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59469174
  
      [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21847/consoleFull) for   PR 2808 at commit [`3821c4d`](https://github.com/apache/spark/commit/3821c4dcc5b4af1519eefcb1e8c687aeb13a2fa9).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59601740
  
      [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/397/consoleFull) for   PR 2808 at commit [`26a7e37`](https://github.com/apache/spark/commit/26a7e379f6135a51478552bfd7c85af449c4bb69).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59636456
  
      [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21879/consoleFull) for   PR 2808 at commit [`8d4bec4`](https://github.com/apache/spark/commit/8d4bec4a5076bcc878498a404e435c0064289d3e).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2808#discussion_r18999350
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -398,6 +498,30 @@ JavaSparkContext sc = ...   //existing JavaSparkContext
     JavaStreamingContext ssc = new JavaStreamingContext(sc, new Duration(1000));
     {% endhighlight %} 
     </div>
    +<div data-lang="python" markdown="1">
    +
    +A [StreamingContext](api/python/pyspark.streaming.html#pyspark.streaming.StreamingContext) object can be created from a [SparkContext](api/python/pyspark.html#pyspark.SparkContext) object.
    +
    +{% highlight python %}
    +from pyspark import SparkContext
    +from pyspark.streaming import StreamingContext
    +
    +sc = SparkContext(master, appName)
    +ssc = StreamingContext(sc, 1)
    +{% endhighlight %}
    +
    +The `appName` parameter is a name for your application to show on the cluster UI.
    +`master` is a [Spark, Mesos or YARN cluster URL](submitting-applications.html#master-urls),
    +or a special __"local[\*]"__ string to run in local mode. In practice, when running on a cluster, 
    +you will not want to hardcode `master` in the program,
    +but rather [launch the application with `spark-submit`](submitting-applications.html) and
    +receive it there. However, for local testing and unit tests, you can pass "local[\*]" to run Spark Streaming
    +in-process (detects the number of cores in the local system).
    +
    +The batch interval must be set based on the latency requirements of your application
    +and available cluster resources. See the [Performance Tuning](#setting-the-right-batch-size)
    +section for more details.
    +</div>
     </div>
     
     After a context is defined, you have to do the follow steps.
    --- End diff --
    
    As long as you're editing this file, it would be nice to fix the incorrect formatting of the list here; the current markdown renders as 
    
    ![image](https://cloud.githubusercontent.com/assets/50748/4673751/260a0d02-55a8-11e4-8ad1-6313cab2d4cc.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2808#discussion_r18999523
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -483,6 +607,9 @@ methods for creating DStreams from files and Akka actors as input sources.
         <div data-lang="java" markdown="1">
     		streamingContext.fileStream<keyClass, valueClass, inputFormatClass>(dataDirectory);
         </div>
    +    <div data-lang="python" markdown="1">
    +		streamingContext.textFileStream(dataDirectory);
    --- End diff --
    
    No semicolons necessary!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59636873
  
    LGTM; it seems fine to me to bump the Jekyll version, since the prior version was really old and didn't seem to properly handle some of the cases that we use here.  We can always revisit if we notice problems.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2808#discussion_r18999281
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -213,6 +213,67 @@ The complete code can be found in the Spark Streaming example
     <br>
     
     </div>
    +<div data-lang="python"  markdown="1" >
    +First, we import StreamingContext, which is the main entry point for all streaming functionality. We create a local StreamingContext with two execution threads, and batch interval of 1 second.
    +
    +{% highlight python %}
    +from pyspark import SparkContext
    +from pyspark.streaming import StreamingContext
    +
    +# Create a local StreamingContext with two working thread and batch interval of 1 second
    +sc = SparkContext("local[2]", "NetworkWordCount")
    +ssc = new StreamingContext(sc, 1)
    --- End diff --
    
    We don't need the `new` in Python.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59576834
  
    @JoshRosen fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59559838
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21861/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59636460
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21879/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59473901
  
      [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21847/consoleFull) for   PR 2808 at commit [`3821c4d`](https://github.com/apache/spark/commit/3821c4dcc5b4af1519eefcb1e8c687aeb13a2fa9).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59140098
  
      [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21756/consoleFull) for   PR 2808 at commit [`7e4bb8a`](https://github.com/apache/spark/commit/7e4bb8a098236bf9fa2e86e22935a45c04c5edd3).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59473908
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21847/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59635066
  
    @JoshRosen updated the readme.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2808#discussion_r18999499
  
    --- Diff: docs/streaming-programming-guide.md ---
    @@ -398,6 +498,30 @@ JavaSparkContext sc = ...   //existing JavaSparkContext
     JavaStreamingContext ssc = new JavaStreamingContext(sc, new Duration(1000));
     {% endhighlight %} 
     </div>
    +<div data-lang="python" markdown="1">
    +
    +A [StreamingContext](api/python/pyspark.streaming.html#pyspark.streaming.StreamingContext) object can be created from a [SparkContext](api/python/pyspark.html#pyspark.SparkContext) object.
    --- End diff --
    
    I was able to generate that file by running
    
    ```
    sphinx-apidoc -o . ../pyspark/
    ```
    
    from the `python/docs` directory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3952] [Streaming] [PySpark] add Python ...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/2808#issuecomment-59581079
  
    Found one more issue (sorry, hopefully this is the last one):
    
    ![image](https://cloud.githubusercontent.com/assets/50748/4686555/40c48ce0-5647-11e4-99b5-45f033218396.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org