[GitHub] DominikSuess commented on a change in pull request #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox <gi...@apache.org>]

DominikSuess commented on a change in pull request #5: SLING-7544 - improving optimized alias lookup to not block during int…
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#discussion_r182082885
 
 

 ##########
 File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
 ##########
 @@ -128,9 +133,9 @@
 
     private Map <String,List <String>> vanityTargets;
 
-    private volatile Map<String, Map<String, String>> aliasMap;
+    private Map<String, Map<String, String>> aliasMap;
     
-	private volatile boolean isAliasMapInitialized = false;
+	private boolean isAliasMapInitialized = false;
 
 Review comment:
   @rombert  ok I revisited the scenario and added the volatile markers again. This should now be sufficient as access is now threadsafe - the aliasmap is not manipulated in the thread despite of assigning a new map I don't see another multi-threading issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services