You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by vrozov <gi...@git.apache.org> on 2018/03/23 02:47:09 UTC
[GitHub] drill pull request #1185: DRILL-6288: Upgrade org.javassist:javassist and or...
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1185
DRILL-6288: Upgrade org.javassist:javassist and org.reflections:reflections
@vdiravka Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL-6288
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1185
----
commit d6b74d59af0cb8fa39b3deb73846a3b45acddfba
Author: Vlad Rozov <vr...@...>
Date: 2018-03-22T22:47:31Z
DRILL-6288: Upgrade org.javassist:javassist and org.reflections:reflections
----
---
[GitHub] drill pull request #1185: DRILL-6288: Upgrade org.javassist:javassist and or...
Posted by vdiravka <gi...@git.apache.org>.
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1185#discussion_r176891810
--- Diff: exec/jdbc-all/pom.xml ---
@@ -559,7 +559,7 @@
This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
</message>
- <maxsize>32000000</maxsize>
+ <maxsize>33000000</maxsize>
--- End diff --
This has increased due to the new size of javassist library?
---
[GitHub] drill pull request #1185: DRILL-6288: Upgrade org.javassist:javassist and or...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1185#discussion_r177499603
--- Diff: exec/jdbc-all/pom.xml ---
@@ -559,7 +559,7 @@
This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
</message>
- <maxsize>32000000</maxsize>
+ <maxsize>33000000</maxsize>
--- End diff --
Yes.
---
[GitHub] drill pull request #1185: DRILL-6288: Upgrade org.javassist:javassist and or...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1185
---