You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by je...@apache.org on 2023/07/24 22:38:52 UTC
[airflow] branch main updated: Remove comment re cli fallbacks, they have been removed (#32818)
This is an automated email from the ASF dual-hosted git repository.
jedcunningham pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new f57ee511e0 Remove comment re cli fallbacks, they have been removed (#32818)
f57ee511e0 is described below
commit f57ee511e0407cf47512febe73f23bd59109d586
Author: Niko Oliveira <on...@amazon.com>
AuthorDate: Mon Jul 24 15:38:46 2023 -0700
Remove comment re cli fallbacks, they have been removed (#32818)
There was a code comment warning that the fallbacks for celery cli
commands should not be removed until some conditions are met, but the
fallbacks were removed in #32775
---
airflow/cli/cli_config.py | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/airflow/cli/cli_config.py b/airflow/cli/cli_config.py
index a68de35b86..8e4c984450 100644
--- a/airflow/cli/cli_config.py
+++ b/airflow/cli/cli_config.py
@@ -823,17 +823,6 @@ ARG_DO_PICKLE = Arg(
action="store_true",
)
-# IMPORTANT NOTE! ONLY FOR CELERY ARGUMENTS
-#
-# Celery configs below have explicit fallback values because celery provider defaults are not yet loaded
-# via provider at the time we parse the command line, so in case it is not set, we need to have manual
-# fallback. After ProvidersManager.initialize_providers_configuration() is called, the fallbacks are
-# not needed anymore and everywhere where you access configuration in provider-specific code and when
-# you are sure that providers configuration has been initialized, you can use conf.get() without fallbacks.
-#
-# DO NOT REMOVE THE FALLBACKS in args parsing even if you are tempted to.
-# TODO: possibly move the commands to providers but that could be big performance hit on the CLI
-# worker
ARG_QUEUES = Arg(
("-q", "--queues"),
help="Comma delimited list of queues to serve",