You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by AndyChenW <gi...@git.apache.org> on 2015/04/10 09:58:50 UTC
[GitHub] cordova-plugin-device pull request: add is_simulator for iOS & And...
GitHub user AndyChenW opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/32
add is_simulator for iOS & Android device
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AndyChenW/cordova-plugin-device feature/add_is_simulator_to_iOS_and_android
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 8e558734ac541d01745ae1950126148c592e90de
Author: Andy Chen <ch...@gmail.com>
Date: 2015-04-10T06:55:25Z
add is_simulator for iOS & Android device
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add is_simulator for iOS & And...
Posted by AndyChenW <gi...@git.apache.org>.
Github user AndyChenW commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119792313
a new pr is created for isSimulator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add is_simulator for iOS & And...
Posted by AndyChenW <gi...@git.apache.org>.
Github user AndyChenW commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119792320
https://github.com/apache/cordova-plugin-device/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add is_simulator for iOS & And...
Posted by AndyChenW <gi...@git.apache.org>.
Github user AndyChenW commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-118271618
hello, any response to pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add is_simulator for iOS & And...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/32#issuecomment-119703244
This looks good, I will look at adding it to windows+wp8
Please change the new property to `isSimulator` instead of `is_simulator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add is_simulator for iOS & And...
Posted by AndyChenW <gi...@git.apache.org>.
Github user AndyChenW closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org