You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/15 00:54:09 UTC

[GitHub] [superset] graceguo-supercat commented on a change in pull request #16674: fix: report with timeout chart

graceguo-supercat commented on a change in pull request #16674:
URL: https://github.com/apache/superset/pull/16674#discussion_r708757782



##########
File path: superset/utils/webdriver.py
##########
@@ -141,6 +141,7 @@ def get_screenshot(
             img = element.screenshot_as_png
         except TimeoutException:
             logger.warning("Selenium timed out requesting url %s", url, exc_info=True)
+            img = element.screenshot_as_png

Review comment:
       i guess it's webdriver raise TimeoutException right? i am not sure how to not raise it...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org