You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/06 11:52:44 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #2482: Fix some code specification issues
codecov-io commented on pull request #2482:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2482#issuecomment-624604593
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482?src=pr&el=h1) Report
> Merging [#2482](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/6a92bef5e36dd6c7100517cfa516ca9c8603d950&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `11.53%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2482 +/- ##
============================================
+ Coverage 36.47% 36.56% +0.08%
- Complexity 2492 2497 +5
============================================
Files 431 431
Lines 19872 19895 +23
Branches 2423 2423
============================================
+ Hits 7249 7275 +26
+ Misses 11971 11967 -4
- Partials 652 653 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...api/dto/resources/visitor/ResourceTreeVisitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvdmlzaXRvci9SZXNvdXJjZVRyZWVWaXNpdG9yLmphdmE=) | `95.45% <ø> (ø)` | `15.00 <0.00> (ø)` | |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `57.06% <0.00%> (ø)` | `67.00 <0.00> (ø)` | |
| [...inscheduler/common/task/datax/DataxParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svZGF0YXgvRGF0YXhQYXJhbWV0ZXJzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mmon/utils/process/ProcessEnvironmentForWin32.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3Byb2Nlc3MvUHJvY2Vzc0Vudmlyb25tZW50Rm9yV2luMzIuamF2YQ==) | `3.73% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...uler/common/utils/process/ProcessImplForWin32.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3Byb2Nlc3MvUHJvY2Vzc0ltcGxGb3JXaW4zMi5qYXZh) | `0.64% <0.00%> (-0.02%)` | `1.00 <0.00> (ø)` | |
| [...olphinscheduler/dao/entity/ProcessInstanceMap.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzSW5zdGFuY2VNYXAuamF2YQ==) | `41.93% <0.00%> (-8.07%)` | `9.00 <0.00> (ø)` | |
| [.../org/apache/dolphinscheduler/dao/entity/Queue.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9RdWV1ZS5qYXZh) | `51.61% <0.00%> (-7.65%)` | `11.00 <0.00> (ø)` | |
| [...rg/apache/dolphinscheduler/dao/entity/Session.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9TZXNzaW9uLmphdmE=) | `41.93% <0.00%> (-8.07%)` | `9.00 <0.00> (ø)` | |
| [...e/dolphinscheduler/dao/utils/MysqlPerformance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL015c3FsUGVyZm9ybWFuY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../dolphinscheduler/service/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQWJzdHJhY3RaS0NsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482?src=pr&el=footer). Last update [6a92bef...413e52e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2482?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org