[jira] [Commented] (SOLR-17182) Eliminate the need for 'solr.useExitableDirectoryReader' sysprop

["Chris M. Hostetter (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-17182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820794#comment-17820794 ] 

Chris M. Hostetter commented on SOLR-17182:
-------------------------------------------

The crux of this idea goes back to a strawman alternative i pitched when when this sysprop was introduced in SOLR-16693...
{quote}I don't fully understand all the complexity here of what changes were made in lucene, but "last resort" strawman proposal that occurs to me is:
 * {{SolrIndexSearcher}} init's & maintain a {{private final ExitableDirectoryReader exitableDirReader}} (independent of the existing {{DirectoryReader}} variable
 * {{SolrIndexSearcher.getIndexReader()}} should be changed to do something like..
{code:java}
return SolrQueryTimeoutImpl.getInstance().isTimeoutEnabled() ? exitableDirReader : reader
{code}
{quote}

With the way the {{QueryLimit}} code has evolved since then, there may be better ways for this to work ... perhaps a {{getLimitedReader()}} method in the {{QueryLimit}} API that can return the "normal" reader for the {{SolrQueryRequest}} if no limits are in use?

> Eliminate the need for 'solr.useExitableDirectoryReader' sysprop
> ----------------------------------------------------------------
>
>                 Key: SOLR-17182
>                 URL: https://issues.apache.org/jira/browse/SOLR-17182
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Chris M. Hostetter
>            Priority: Major
>
> As the {{QueryLimit}} functionality in Solr gets beefed up, and supports multiple types of limits, it would be nice if we could find a way to eliminate the need for the {{solr.useExitableDirectoryReader}} sysprop, and instead just have codepaths that use the underlying IndexReader automatically get a reader that enforces the limits if/when limits are in use.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org