[jira] [Comment Edited] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222751#comment-17222751 ] 

Jens Geyer edited comment on THRIFT-5299 at 10/29/20, 7:44 AM:
---------------------------------------------------------------

Sure, who needs testcases anyway. Stupid me. It is always on us to prove it works, not on you who is claiming there is an error. How did I dare to even ask for a testcase? What was in my mind?


was (Author: jensg):
Sure, who needs testcases anyway. Stupid me. 

> rs implementation compact protocol seq_id should not use zigzag encoding.
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-5299
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5299
>             Project: Thrift
>          Issue Type: Bug
>          Components: Rust - Library
>    Affects Versions: 0.13.0
>            Reporter: shuo li
>            Priority: Major
>
> While reviewing code, I discovered a bug in compact protocol.
> The seq_id in message header is decoded with integer-encoding's i32, which uses zigzag decode implicitly. 
>  
>  
> EDIT: correct the title and desc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)