[GitHub] chetanmeh commented on a change in pull request #4047: improve splunk query; use consistent format for log output

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4047: improve splunk query; use consistent format for log output
URL: https://github.com/apache/incubator-openwhisk/pull/4047#discussion_r222189714
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/logging/SplunkLogStore.scala
 ##########
 @@ -60,14 +60,24 @@ case class SplunkLogStoreConfig(host: String,
                                 username: String,
                                 password: String,
                                 index: String,
+                                logTimestampField: String,
+                                logStreamField: String,
                                 logMessageField: String,
                                 activationIdField: String,
+                                queryTimestampOffsetSeconds: Int,
                                 disableSNI: Boolean)
 case class SplunkResponse(results: Vector[JsObject])
 object SplunkResponseJsonProtocol extends DefaultJsonProtocol {
   implicit val orderFormat = jsonFormat1(SplunkResponse)
 }
 
+/**
+ * Represents a single log line as read from a docker log
+ */
+protected[core] case class SplunkLogLine(time: String, stream: String, log: String) {
 
 Review comment:
   This class is currently not used. Probably it was to be used in unmarshalling at L146 below?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services