You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Michael Brohl <mi...@ecomify.de> on 2018/10/26 10:28:22 UTC
Re: Pursuing the “120 chars max” guideline
+1 for not reformatting all at once but only if there are changes anyway.
The patch should mention this because it will make reviews more complex.
Regards,
Michael
Am 26.10.18 um 11:13 schrieb Mathieu Lirzin:
> Hello Jacques,
>
> Jacques Le Roux <ja...@les7arts.com> writes:
>
>> Yes you are right, the whole file should be reformatted.
>>
>> This "around 120 chars max" rule is "new" (few years) and most of the
>> code there is more than a decade.
> OK, sure.
>
>> If nobody disagree we could have a task Jira to reformat the code of
>> the most important classes (with subtasks maybe, or simply patches for
>> concerned classes).
> I sympathise but I am not sure about this strategy, which depending on
> the capabilities of your VCS might obscure the commit history. I would
> recommend to simply use the “120 chars max” guideline for newly added
> code and when refactoring existing one.
>
> WDYT?
>