You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/29 10:32:57 UTC
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2497: [KYUUBI #2495] [Improvement] clear logRoot dir in SparkJsonLoggingEventHandlerSuite
yaooqinn commented on code in PR #2497:
URL: https://github.com/apache/incubator-kyuubi/pull/2497#discussion_r861684213
##########
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/events/handler/SparkJsonLoggingEventHandlerSuite.scala:
##########
@@ -46,6 +46,16 @@ class SparkJsonLoggingEventHandlerSuite extends WithSparkSQLEngine with HiveJDBC
override protected def jdbcUrl: String = getJdbcUrl
+ override def afterAll(): Unit = {
+ super.afterAll()
+ val fileSystem: FileSystem = FileSystem.get(new Configuration())
Review Comment:
Utils.createTempDir() will deleteOnExist？ is is not working？
##########
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/events/handler/SparkJsonLoggingEventHandlerSuite.scala:
##########
@@ -46,6 +46,16 @@ class SparkJsonLoggingEventHandlerSuite extends WithSparkSQLEngine with HiveJDBC
override protected def jdbcUrl: String = getJdbcUrl
+ override def afterAll(): Unit = {
+ super.afterAll()
+ val fileSystem: FileSystem = FileSystem.get(new Configuration())
Review Comment:
Utils.createTempDir() will deleteOnExit？ is is not working？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org