[GitHub] [yunikorn-k8shim] craigcondit commented on a diff in pull request #466: [YUNIKORN-1196] Build against Kubernetes 1.23.12

[GitBox <gi...@apache.org>]

craigcondit commented on code in PR #466:
URL: https://github.com/apache/yunikorn-k8shim/pull/466#discussion_r1019348286


##########
deployments/image/plugin/start-yunikorn-plugin.sh:
##########
@@ -17,13 +17,15 @@
 # limitations under the License.
 
 cd "${HOME}" || exit
+
+# Embed scheduler name into config file
+sed 's/schedulerName:.*/schedulerName: '"${SCHEDULER_NAME}"'/' < "${SCHEDULER_CONFIG}" > /tmp/scheduler-config.yaml || exit

Review Comment:
   The point was to allow customizing the scheduler name, which as of 1.23 has to be in the scheduler-config file. However, as part of the configv2 redesign, we're removing the ability to change the scheduler name (which never really worked anyway). So I'm removing this code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org