[jira] [Created] (MSHADE-256) Manifest transformer should reuse archiver plugin

["Brian Oxley (JIRA)" <ji...@apache.org>]

Brian Oxley created MSHADE-256:
----------------------------------

             Summary: Manifest transformer should reuse archiver plugin
                 Key: MSHADE-256
                 URL: https://issues.apache.org/jira/browse/MSHADE-256
             Project: Maven Shade Plugin
          Issue Type: Improvement
    Affects Versions: 3.0.0
            Reporter: Brian Oxley


I noted that for the manifest transformer custom handles manifest entries, rather than reuses the archiver plugin (as, for example, the jar plugin does).  I confirmed this in the transformer resource sources.

For example, the instructions for adding a main class entry rely on a custom manifest entry ("Main-Class") rather than reusing the "mainClass" tag from archiver:

https://maven.apache.org/plugins/maven-shade-plugin/examples/executable-jar.html

(Verified through trial and error.)

Similarly, I could not use the "index" tag to index the shaded jar.  Indexing seems particularly apt for the large number of classes that appear in a shaded jar.  And likewise for other archiver plugin features.

Delegating to the archiver plugin would provide a more uniform way of configuring my pom for manifest handling, and keep the shade plugin up to date w.r.t. archiver features and fixes.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)