You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/11/27 11:43:19 UTC
Review Request 71832: Added 'issocket()' function to stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71832/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Bugs: MESOS-10036
https://issues.apache.org/jira/browse/MESOS-10036
Repository: mesos
Description
-------
Added a new helper 'issocket()' that tells whether a given
file is a socket or not.
Diffs
-----
3rdparty/stout/include/stout/os/posix/stat.hpp 74e0c934baa29ec936e8011221a3da29dd67a465
Diff: https://reviews.apache.org/r/71832/diff/1/
Testing
-------
Manual testing by using it in the subsequent patch.
Thanks,
Benno Evers
Re: Review Request 71832: Added 'issocket()' function to stout.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71832/#review218821
-----------------------------------------------------------
Ship it!
Can you add a trivial patch for this (`issocket` for socket returns `true`, for a non-socket returns `false`).
- Benjamin Bannier
On Nov. 27, 2019, 12:43 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71832/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2019, 12:43 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-10036
> https://issues.apache.org/jira/browse/MESOS-10036
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new helper 'issocket()' that tells whether a given
> file is a socket or not.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/stat.hpp 74e0c934baa29ec936e8011221a3da29dd67a465
>
>
> Diff: https://reviews.apache.org/r/71832/diff/1/
>
>
> Testing
> -------
>
> Manual testing by using it in the subsequent patch.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71832: Added new issocket() function to stout.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71832/
-----------------------------------------------------------
(Updated Dec. 3, 2019, 6:27 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Changes
-------
Changed `strcpy()` -> `strncpy()`.
Summary (updated)
-----------------
Added new issocket() function to stout.
Bugs: MESOS-10036
https://issues.apache.org/jira/browse/MESOS-10036
Repository: mesos
Description (updated)
-------
Added a new function 'os::stat::issocket()' that tells whether a given
file is a socket or not.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/stat.hpp 74e0c934baa29ec936e8011221a3da29dd67a465
3rdparty/stout/tests/os/socket_tests.cpp 9ca236cb15525004d8c165ccd19f63902729b04d
Diff: https://reviews.apache.org/r/71832/diff/3/
Changes: https://reviews.apache.org/r/71832/diff/2-3/
Testing
-------
* Manual testing by using it in the subsequent patch.
* `./stout-tests`
Thanks,
Benno Evers
Re: Review Request 71832: Added 'issocket()' helper to stout.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71832/
-----------------------------------------------------------
(Updated Nov. 27, 2019, 2:54 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Changes
-------
Added test.
Summary (updated)
-----------------
Added 'issocket()' helper to stout.
Bugs: MESOS-10036
https://issues.apache.org/jira/browse/MESOS-10036
Repository: mesos
Description
-------
Added a new helper 'issocket()' that tells whether a given
file is a socket or not.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/posix/stat.hpp 74e0c934baa29ec936e8011221a3da29dd67a465
3rdparty/stout/tests/os/socket_tests.cpp 9ca236cb15525004d8c165ccd19f63902729b04d
Diff: https://reviews.apache.org/r/71832/diff/2/
Changes: https://reviews.apache.org/r/71832/diff/1-2/
Testing (updated)
-------
* Manual testing by using it in the subsequent patch.
* `./stout-tests`
Thanks,
Benno Evers