You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2022/01/05 00:34:41 UTC
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18119
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
---
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/util/test_file_parser.py
6 files changed, 255 insertions(+), 170 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18119/1
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 1:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/impala_test_suite.py@692
PS1, Line 692: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/impala_test_suite.py@744
PS1, Line 744: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py
File tests/common/test_section.py:
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@27
PS1, Line 27: class TestSection(object):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@57
PS1, Line 57: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@71
PS1, Line 71: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@75
PS1, Line 75: =
flake8: E711 comparison to None should be 'if cond is None:'
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@80
PS1, Line 80: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@93
PS1, Line 93: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@107
PS1, Line 107: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@111
PS1, Line 111: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@128
PS1, Line 128:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@128
PS1, Line 128: return default_val
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@139
PS1, Line 139: def test_section_create(section_text, valid_section_names=None, skip_unknown_sections=False):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/18119/1/tests/common/test_section.py@139
PS1, Line 139: e
flake8: E501 line too long (93 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 00:35:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18119/6/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/18119/6/testdata/bin/generate-schema-statements.py@658
PS6, Line 658: ,
flake8: E231 missing whitespace after ','
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 01:14:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7716/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 04:08:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7719/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 19:22:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18119
to look at the new patch set (#4).
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
---
M testdata/bin/generate-schema-statements.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/util/test_file_parser.py
7 files changed, 283 insertions(+), 193 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18119/4
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7719/
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 21:02:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9968/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 04:29:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9973/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 23:40:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18119
to look at the new patch set (#2).
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
---
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/util/test_file_parser.py
6 files changed, 258 insertions(+), 170 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18119/2
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7715/
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 03:08:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7715/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 01:26:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9974/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 01:37:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7721/
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 02:56:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9976/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 03:40:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18119
to look at the new patch set (#5).
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
---
M testdata/bin/generate-schema-statements.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/util/test_file_parser.py
7 files changed, 283 insertions(+), 193 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18119/5
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18119
to look at the new patch set (#7).
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
---
M testdata/bin/generate-schema-statements.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/util/test_file_parser.py
7 files changed, 284 insertions(+), 193 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18119/7
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9965/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 01:14:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9971/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 18:42:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18119
to look at the new patch set (#6).
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
---
M testdata/bin/generate-schema-statements.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/util/test_file_parser.py
7 files changed, 283 insertions(+), 193 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18119/6
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7721/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 01:14:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7716/
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 05:45:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7720/
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 01:01:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7722/
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 09:45:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has abandoned this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7720/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 23:17:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7722/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Jan 2022 03:17:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9964/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 00:58:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18119
to look at the new patch set (#3).
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
---
M testdata/bin/generate-schema-statements.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/util/test_file_parser.py
7 files changed, 281 insertions(+), 192 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18119/3
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11070: Create TestSection class.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18119 )
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18119/3/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/18119/3/testdata/bin/generate-schema-statements.py@679
PS3, Line 679: E
flake8: E501 line too long (107 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/18119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b811d131c3c399ac4f01d7da87759c418905fd
Gerrit-Change-Number: 18119
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 04:08:09 +0000
Gerrit-HasComments: Yes