[GitHub] [brooklyn-server] duncangrant commented on pull request #1394: Workflow entity child and member access pt 184904864

["duncangrant (via GitHub)" <gi...@apache.org>]

duncangrant commented on PR #1394:
URL: https://github.com/apache/brooklyn-server/pull/1394#issuecomment-1520372550

   This looks good to me.  Thanks @frogfather .
   It does look like there are a couple of tests that are failing intermittently.  I've copied these below and will see if I can tell what's going on.
   
   java.lang.AssertionError: null: lists don't have the same size expected [8] but found [16]
   
   	at org.apache.brooklyn.core.workflow.WorkflowBasicTest.testWorkflowLogging(WorkflowBasicTest.java:381)
   
   
   
   testSimpleErrorHandlerOnStep(org.apache.brooklyn.core.workflow.WorkflowPersistReplayErrorsTest)  Time elapsed: 0.276 sec  <<< FAILURE!
   
   java.lang.AssertionError: List of test is different length to list of data to test expected [8] but found [112]
   
   	at org.apache.brooklyn.core.workflow.WorkflowPersistReplayErrorsTest.testSimpleErrorHandlerOnStep(WorkflowPersistReplayErrorsTest.java:599)
   
   
   
   testSimpleErrorHandlerOnWorkflow(org.apache.brooklyn.core.workflow.WorkflowPersistReplayErrorsTest)  Time elapsed: 0.271 sec  <<< FAILURE!
   
   java.lang.AssertionError: List of test is different length to list of data to test expected [9] but found [111]
   
   	at org.apache.brooklyn.core.workflow.WorkflowPersistReplayErrorsTest.testSimpleErrorHandlerOnWorkflow(WorkflowPersistReplayErrorsTest.java:630)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org