You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Files <fi...@poetryunlimited.com> on 2003/09/30 03:35:44 UTC

Re: Patches submitted

Ok. So like out of curiosity, do I have to resubmit said patches with [PATCH] in
the subject line?

Will the patch manager not pick them up otherwise?

I can if someone tells mw if this is necessary.

Thanks.

Shamim Islam
BA BS


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Patches submitted

Posted by pl...@lanminds.com.
In a message dated: Tue, 30 Sep 2003 03:35:44 -0000
"Files" said:

>Ok. So like out of curiosity, do I have to resubmit said patches with [PATCH] 
>in the subject line?
>
>Will the patch manager not pick them up otherwise?
>
>I can if someone tells mw if this is necessary.

Have you read HACKING?  Please see the section entitled:

    Patch submission guidelines

In short, [PATCH] is a required convention which everyone who submits 
patches should adhere to.
-- 
Seeya,
Paul

GPG Key fingerprint = 1660 FECC 5D21 D286 F853  E808 BB07 9239 53F1 28EE

	 If you're not having fun, you're not doing it right!



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Patches submitted

Posted by Sander Roobol <ph...@wanadoo.nl>.
On Tue, Sep 30, 2003 at 03:35:44AM +0000, Files wrote:
> Ok. So like out of curiosity, do I have to resubmit said patches with [PATCH] in
> the subject line?
> Will the patch manager not pick them up otherwise?
> I can if someone tells mw if this is necessary.

No, that's not necessary, I've picked them up anyway. I currently don't use any
automatic filtering for this.
However, I'd prefer [PATCH] in the subject line since it's easier for me to
spot, and it's what HACKING recommends.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Patches submitted

Posted by Scott Lamb <sl...@slamb.org>.
Files wrote:

> Ok. So like out of curiosity, do I have to resubmit said patches with [PATCH] in
> the subject line?
> 
> Will the patch manager not pick them up otherwise?
> 
> I can if someone tells mw if this is necessary.

Yes, I think you should. I believe people use procmail rules to grab 
everything with [PATCH] in the subject. "Patch:" is not good enough.

Scott


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org