You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shounakmk219 (via GitHub)" <gi...@apache.org> on 2023/05/03 16:28:09 UTC
[GitHub] [pinot] shounakmk219 opened a new pull request, #10716: Fix githubEvents table for quickstart recipes
shounakmk219 opened a new pull request, #10716:
URL: https://github.com/apache/pinot/pull/10716
The PR addresses the bug raised in the issue [#10675](https://github.com/apache/pinot/issues/10675)
The changes include:
1. Rename the `examples/stream/githubEvents` directory to `examples/stream/pullRequestMergedEvents` as the files it contains creates a table named `pullRequestMergedEvents`
2. Copy the `examples/minions/stream/githubEvents` table to `examples/stream/githubEvents` so that we avoid the `RealtimeToOfflineSegmentsTask` which is present in the minions sub path table config and leads to the exception logs mentioned in the linked issue
3. Increase the `retentionTimeValue` for `githubEvents` table to 15 years as the table contains data from 2021.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10716: Fix githubEvents table for quickstart recipes
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10716:
URL: https://github.com/apache/pinot/pull/10716#issuecomment-1533430278
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10716?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10716](https://app.codecov.io/gh/apache/pinot/pull/10716?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (008b3dc) into [master](https://app.codecov.io/gh/apache/pinot/commit/cad764dcbe8793f7fb1cbec37051c27a753e4f30?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cad764d) will **decrease** coverage by `38.24%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 008b3dc differs from pull request most recent head db86638. Consider uploading reports for the commit db86638 to get more accurate results
```diff
@@ Coverage Diff @@
## master #10716 +/- ##
=============================================
- Coverage 70.32% 32.08% -38.24%
+ Complexity 6429 453 -5976
=============================================
Files 2112 2112
Lines 114056 114056
Branches 17226 17226
=============================================
- Hits 80213 36600 -43613
- Misses 28244 74150 +45906
+ Partials 5599 3306 -2293
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.42% <ø> (+0.07%)` | :arrow_up: |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.85% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1332 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10716/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 merged pull request #10716: Fix githubEvents table for quickstart recipes
Posted by "saurabhd336 (via GitHub)" <gi...@apache.org>.
saurabhd336 merged PR #10716:
URL: https://github.com/apache/pinot/pull/10716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org