You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2016/11/28 13:40:17 UTC
Review Request 54123: AMBARI-18992: Stack version input text field on
Register Version page should align properly even when resizing the
page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54123/
-----------------------------------------------------------
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-18992
https://issues.apache.org/jira/browse/AMBARI-18992
Repository: ambari
Description
-------
When the page is maximized to full size, the input field left boarder goes beyond the outer boarder.
when the page is resized, the input field may tuck under the HDP x.x word and overlaps with the Name: label.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html a614a0d
Diff: https://reviews.apache.org/r/54123/diff/
Testing
-------
patched a trunk cluster with the change, resize web browsers to various sizes, verify the "Name:" label, the "HDP.2.6." prefix label and the text field align properly and does not protrude the border.
Thanks,
Di Li
Re: Review Request 54123: AMBARI-18992: Stack version input text
field on
Register Version page should align properly even when resizing the page
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54123/#review157025
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On Nov. 28, 2016, 1:40 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54123/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 1:40 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-18992
> https://issues.apache.org/jira/browse/AMBARI-18992
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the page is maximized to full size, the input field left boarder goes beyond the outer boarder. When the page is resized, the input field may tuck under the HDP x.x word and overlaps with the Name: label.
>
> Screenshots for the issues are attached to the JIRA.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html a614a0d
>
> Diff: https://reviews.apache.org/r/54123/diff/
>
>
> Testing
> -------
>
> patched a trunk cluster with the change, resize web browsers to various sizes, verify the "Name:" label, the "HDP.2.6." prefix label and the text field align properly and does not protrude the border.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 54123: AMBARI-18992: Stack version input text
field on
Register Version page should align properly even when resizing the page
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54123/
-----------------------------------------------------------
(Updated Nov. 28, 2016, 1:40 p.m.)
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-18992
https://issues.apache.org/jira/browse/AMBARI-18992
Repository: ambari
Description (updated)
-------
When the page is maximized to full size, the input field left boarder goes beyond the outer boarder. When the page is resized, the input field may tuck under the HDP x.x word and overlaps with the Name: label.
Screenshots for the issues are attached to the JIRA.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html a614a0d
Diff: https://reviews.apache.org/r/54123/diff/
Testing
-------
patched a trunk cluster with the change, resize web browsers to various sizes, verify the "Name:" label, the "HDP.2.6." prefix label and the text field align properly and does not protrude the border.
Thanks,
Di Li