You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by wy...@apache.org on 2026/08/25 13:54:27 UTC
(maka) branch main updated: fix(desktop): hide single Host settings selector (#3799)
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/maka.git
The following commit(s) were added to refs/heads/main by this push:
new 421acbeff fix(desktop): hide single Host settings selector (#3799)
421acbeff is described below
commit 421acbeffc65bf47ed05fdc8d2811e15a97246c9
Author: Wang <m4...@gmail.com>
AuthorDate: Tue Aug 25 21:54:21 2026 +0800
fix(desktop): hide single Host settings selector (#3799)
* fix(desktop): hide single Host settings selector
The Host selector provides no choice when only one profile is enabled. Render it only when multiple enabled Hosts are available while retaining unavailable enabled entries in the selector.
Generated-by: Codex
* test(desktop): await multi-Host settings selector
Wait for the asynchronously refreshed Host catalog before interacting with the selector in the generation-revalidation story.
---
apps/desktop/src/renderer/settings/settings-surface.tsx | 2 +-
apps/desktop/stories/settings/settings-pages.stories.tsx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/apps/desktop/src/renderer/settings/settings-surface.tsx b/apps/desktop/src/renderer/settings/settings-surface.tsx
index 6ac34ebe3..a9f3dd92f 100644
--- a/apps/desktop/src/renderer/settings/settings-surface.tsx
+++ b/apps/desktop/src/renderer/settings/settings-surface.tsx
@@ -891,7 +891,7 @@ export function SettingsSurface(props: {
<p className="settingsPageHeaderDescription">{headerCopy.description}</p>
)}
</div>
- {showsRuntimeHost && runtimeHostOptions.length > 0 ? (
+ {showsRuntimeHost && runtimeHostOptions.length > 1 ? (
<div className="settingsRuntimeHostSelector">
<Selector
label={copy.runtimeHost}
diff --git a/apps/desktop/stories/settings/settings-pages.stories.tsx b/apps/desktop/stories/settings/settings-pages.stories.tsx
index 6fed9d5b6..ae7910e74 100644
--- a/apps/desktop/stories/settings/settings-pages.stories.tsx
+++ b/apps/desktop/stories/settings/settings-pages.stories.tsx
@@ -2205,7 +2205,7 @@ export const ModelsConnectionsHostGenerationRevalidation: Story = {
isDefault: true,
});
- await userEvent.click(canvas.getByRole('combobox', { name: 'Runtime Host' }));
+ await userEvent.click(await canvas.findByRole('combobox', { name: 'Runtime Host' }));
await within(document.body).findByRole('option', { name: 'Remote' });
await userEvent.keyboard('{Escape}');
await expect(boundary).toHaveAttribute('inert');
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org