mod_auth_ldap changes (was: Re: cvs commit: httpd-2.0 CHANGES)

[Brad Nicholes <BN...@novell.com>]

The LDAP memory leak fix was added to the 2.1 tree with the SSL changes
that I commited a couple of weeks ago.  Since I had to fix the caching
fault in both trees anyway, I also back ported the memory leak fixes to
the 2.0 tree.  Both trees are in sync as far as the caching fault and
memory leak fixes go.  I would still like to back port the SSL changes
and then propose that mod_auth_ldap be moved out of experimental.

Brad

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> wrowe@apache.org Wednesday, February 26, 2003 12:03:00 PM >>>
wrowe       2003/02/26 11:03:00

  Modified:    .        CHANGES
  Log:
    Brad, Stas, I presume these patches were first committed to
2.1-dev.
    Please keep the CHANGES logs in sync!
  
  Revision  Changes    Path
  1.1090    +13 -1     httpd-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/CHANGES,v
  retrieving revision 1.1089
  retrieving revision 1.1090
  diff -u -r1.1089 -r1.1090
  --- CHANGES	25 Feb 2003 22:59:56 -0000	1.1089
  +++ CHANGES	26 Feb 2003 19:02:59 -0000	1.1090
  @@ -135,9 +135,21 @@
   
   Changes with Apache 2.0.45
   
  +  *) Enhance the behavior of mod_isapi's WriteClient() callback to
  +     provide better emulation for isapi modules that presume that
the
  +     first WriteClient() call may send status and headers.  An
example
  +     of WriteClient() abuse is the foxisapi module, which relies on
  +     that assumpion and now works.  [William Rowe, Milan Kosina]
  +
  +  *) Check the return value of ap_run_pre_connection(). So if the
  +     pre_connection phase fails (without setting c->aborted)
  +     ap_run_process_connection is not executed. [Stas Bekman]
  +
     *) Fixed a problem with mod_ldap which caused it to fault when
caching
        was disabled.  Needed to make sure that the code did not
  -     attempt to use the cache if it didn't exist. [Brad Nicholes]
  +     attempt to use the cache if it didn't exist. Also fixed some
memory
  +     leaks which were due to not releasing LDAP resources on error
  +     conditions.  [Brad Nicholes]
        
     *) Hook mod_proxy's fixup before mod_rewrite's fixup, so that by
        mod_rewrite proxied URLs will not be escaped accidentally by
  
  
  

Apache 2 Win32 Socket Opt: send buffer size?

["Jess M. Holle" <je...@ptc.com>]

Apache 2 (2.0.43 and 2.0.44 at least) ignores attempts to set the send 
buffer size on a socket in apr_socket_opt_set 
apr/network_io/win32/sockopt.c.

Addition of:

        case APR_SO_SNDBUF:
                if (setsockopt(sock->socketdes, SOL_SOCKET, SO_SNDBUF,
    (void *)&on,
                    sizeof(int)) == -1) {
                       return apr_get_netos_error();
                }
                break;

to the switch on 'opt' makes Apache 2 on Windows obey the send buffer 
size configuration options -- which seems to make a big performance 
difference in some cases.

Is there any reason not to include this?  Could someone commit such a 
change to Apache 2?

--
Jess Holle