You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Konstantin Shaposhnikov (JIRA)" <ji...@apache.org> on 2015/05/16 03:48:00 UTC
[jira] [Comment Edited] (THRIFT-3131) Consolidate suggested import
path for go thrift library to git.apache.org in docs and code
[ https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546491#comment-14546491 ]
Konstantin Shaposhnikov edited comment on THRIFT-3131 at 5/16/15 1:47 AM:
--------------------------------------------------------------------------
UPDATE: Please ignore my last comment. I based it on wrong assumptions.
Basically it looks like when I created this ticket git://git.apache.org was down. So "go get" tried to download git.apache.org/thrift.git/lib/go/thrift using HTTP scheme. But due to problem described in https://github.com/golang/go/issues/10797 it failed.
To summarize the current status:
go get git.apache.org/thrift.git/lib/go/thrift
- works with Go 1.4 given that Git at git.apache.org is up
- will work with Go 1.5 given that Git at git.apache.org is up and -insecure option is specified
- will work with Go 1.5 without any additional command line flags if Apache adds HTTPS support and my patch is accepted for GO 1.5
Whew, I never thought this simple issue be that complicated ;)
So to resolve this issue THRIFT-2537 commit just need to be reverted. I will create a pull request.
After Go 1.5 is released and if Apache doesn't add HTTPS a comment about -insecure option will need to be added. I will keep an eye on that.
was (Author: k.shaposhnikov@gmail.com):
UPDATE: Please ignore my last comment. I based it on wrong assumptions.
Basically it looks like when I created this ticket git://git.apache.org was down. So "go get" tried to download git.apache.org/thrift.git/lib/go/thrift using HTTP scheme. But due to problem described in https://github.com/golang/go/issues/10797 it failed.
To summarize the current status:
go get git.apache.org/thrift.git/lib/go/thrift
- works with Git 1.4 given that Git at git.apache.org is up
- will work with Git 1.5 given that Git at git.apache.org is up and -insecure option is specified
- will work with Git 1.5 without any additional command line flags if Apache adds HTTPS support and my patch is accepted for GO 1.5
Whew, I never thought this simple issue be that complicated ;)
So to resolve this issue THRIFT-2537 commit just need to be reverted. I will create a pull request.
After Go 1.5 is released and if Apache doesn't add HTTPS a comment about -insecure option will need to be added. I will keep an eye on that.
> Consolidate suggested import path for go thrift library to git.apache.org in docs and code
> ------------------------------------------------------------------------------------------
>
> Key: THRIFT-3131
> URL: https://issues.apache.org/jira/browse/THRIFT-3131
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler, Go - Library
> Reporter: Konstantin Shaposhnikov
> Assignee: Konstantin Shaposhnikov
>
> https://github.com/apache/thrift/blob/master/lib/go/README.md suggests to use the following import path for go thrift library:
> git-wip-us.apache.org/repos/asf/thrift.git/lib/go/thrift
> However thrift compiler uses different import path in the generated files by default:
> git.apache.org/thrift.git/lib/go/thrift
> To avoid confusion it would be good to use a single import path both in the generated code and in the user documentation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)