You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/27 18:24:45 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request #13529: support dynamic config for replicationProducerQueueSize
lordcheng10 opened a new pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529
### Motivation
support dynamic config for replicationProducerQueueSize
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1004720296
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r776129068
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
Yes, It won't apply to existing replicators.
But I understand that existing replicators can also take effect by deleting and rebuilding existing replicators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1003060002
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002836553
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r775701862
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
IMO, no need to restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r775700537
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
Do we need broker restart for this to take effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006249035
@Jason918 I think this pull request is ready to merge. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318
> @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start up. Have you tested the usage of `dynamic`? (I see that we use it elsewhere in the modified file, but I don't see how it is working.) Once we make sure that it works as expected, I'll merge this.
1. pulsar will find the field with dynamic = true through reflection:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2365-L2374
2. When we update the configuration on zk through the command, the listening callback will be triggered:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2067-L2082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005402254
PTAL,thanks! @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1008484973
happy new year!
If no problem, Can you help me to merge it? @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r776139592
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
> At least the newly created replicators can take effect immediately
I think we need to add this in the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002218098
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318
> @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start up. Have you tested the usage of `dynamic`? (I see that we use it elsewhere in the modified file, but I don't see how it is working.) Once we make sure that it works as expected, I'll merge this.
1. pulsar will find the field with dynamic = true through reflection:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2365-L2374
2. When we update the configuration on zk through the command, the listening callback will be triggered:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2079-L2083
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2298-L2336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1003407863
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002838316
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r776147709
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
OK I will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r776322128
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
> > At least the newly created replicators can take effect immediately
>
> I think we need to add this in the doc.
like this? @Jason918
@FieldContext(
category = CATEGORY_REPLICATION,
dynamic = true,
doc = "Replicator producer queue size. "
+ "When dynamically modified, it only takes effect for the newly added replicators"
)
private int replicationProducerQueueSize = 1000;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002366256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1001839806
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002365538
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1003473854
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1007385195
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1008231768
ping. can someone please review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005053295
@lhotari PTAL,thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005053295
@lhotari PTAL,thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005402894
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002868882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006218883
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1009980281
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1010938034
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318
> @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start up. Have you tested the usage of `dynamic`? (I see that we use it elsewhere in the modified file, but I don't see how it is working.) Once we make sure that it works as expected, I'll merge this.
1. pulsar will find the field with dynamic = true through reflection:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2365-L2374
2. When we update the configuration on zk through the command, the listening callback will be triggered:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2067-L2082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r776129175
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
At least the newly created replicators can take effect immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1008231768
ping. can someone please review the PR?
can we merge this PR as it's been open for long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1008231768
ping.
can someone please review the PR?
can we merge this PR as it's been open for long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005401782
PTAL,thanks! @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318
> @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start up. Have you tested the usage of `dynamic`? (I see that we use it elsewhere in the modified file, but I don't see how it is working.) Once we make sure that it works as expected, I'll merge this.
1. pulsar will find the field with dynamic = true through reflection:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2365-L2374
2. When we update the configuration on zk through the command, the listening callback will be triggered:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2067-L2085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1008484973
happy new year!
If no problem, Can you help me to meet it? @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002885732
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002868882
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011832179
@lordcheng10 - thanks for the explanation and references. I didn't know it worked that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1001818338
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1001830347
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002364955
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006249035
@Jason918 I think this pull request is ready to merge. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005402254
PTAL,thanks! @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1008928840
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1010383678
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1004245610
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005401782
PTAL,thanks! @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 edited a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318
> @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start up. Have you tested the usage of `dynamic`? (I see that we use it elsewhere in the modified file, but I don't see how it is working.) Once we make sure that it works as expected, I'll merge this.
1. pulsar will find the field with dynamic = true through reflection: @michaeljmarshall
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2365-L2374
2. When we update the configuration on zk through the command, the listening callback will be triggered:
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2079-L2083
https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2298-L2336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall merged pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 closed pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 closed pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002988521
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r775704986
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
It won't apply to existing replicators, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1001829199
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005454497
@codelipenghui PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006235775
@Shoothzj PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005402894
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1005454497
@codelipenghui PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006235775
@Shoothzj PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1004245610
pung
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1002366256
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1001818390
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a change in pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on a change in pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#discussion_r776322128
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2021,6 +2021,7 @@
private String replicatorPrefix = "pulsar.repl";
@FieldContext(
category = CATEGORY_REPLICATION,
+ dynamic = true,
Review comment:
> > At least the newly created replicators can take effect immediately
>
> I think we need to add this in the doc.
like this?
doc = "Replicator producer queue size. "
+ "When dynamically modified, it only takes effect for the newly added replicators"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1003568174
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1007385195
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #13529:
URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1009591555
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org