[jira] [Commented] (ZOOKEEPER-1321) Add number of client connections metric in JMX and srvr

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175049#comment-13175049 ] 

Hadoop QA commented on ZOOKEEPER-1321:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12508429/ZOOKEEPER-1321_trunk.patch
  against trunk revision 1221868.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/851//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/851//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/851//console

This message is automatically generated.
                
> Add number of client connections metric in JMX and srvr
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-1321
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1321
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.3.4, 3.4.2
>            Reporter: Neha Narkhede
>              Labels: patch
>         Attachments: ZOOKEEPER-1321_trunk.patch
>
>
> The related conversation on the zookeeper user mailing list is here - http://apache.markmail.org/message/4jjcmooniowwugu2?q=+list:org.apache.hadoop.zookeeper-user
> It is useful to be able to monitor the number of disconnect operations on a client. This is generally indicative of a client going through large number of GC and hence disconnecting way too often from a zookeeper cluster. 
> Today, this information is only indirectly exposed as part of the stat command which requires counting the results. That's alot of work for the server to do just to get connection count. 
> For monitoring purposes, it will be useful to have this exposed through JMX and 4lw srvr.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira