You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/03/13 08:37:00 UTC
Review Request: CLOUODSTACK-1645 : Resources limit is not validated with
update compute offering [ Instances are updated to higher CPU/Memory
resources though there are no resources available @ account/domain]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9892/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.
Description
-------
CLOUDSTACK-1645 : Resources limit is not validated with update compute offering [ Instances are updated to higher CPU/Memory resources though there are no resources available @ account/domain]
This addresses bug CLOUDSTACK-1645.
Diffs
-----
api/src/com/cloud/vm/UserVmService.java ea89eda
api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 6719b8f
server/src/com/cloud/vm/UserVmManagerImpl.java 88086ce
Diff: https://reviews.apache.org/r/9892/diff/
Testing
-------
Tests:
1. deploy an instance.
2. stop the instance.
3. change service offering.
a) to higher resources -- if resources are not within account resource limits, CS throws resourceAllocationException else service offering successfully changed.
b) to lower resources -- success.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUODSTACK-1645 : Resources limit is not validated with
update compute offering [ Instances are updated to higher CPU/Memory
resources though there are no resources available @ account/domain]
Posted by Min Chen <mi...@citrix.com>.
> On March 14, 2013, 9:05 p.m., Min Chen wrote:
> > Ship It!
Committed to master 105618896bab9de790065c3913cc33eb878ead1b
- Min
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9892/#review17916
-----------------------------------------------------------
On March 13, 2013, 7:36 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9892/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 7:36 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-1645 : Resources limit is not validated with update compute offering [ Instances are updated to higher CPU/Memory resources though there are no resources available @ account/domain]
>
>
> This addresses bug CLOUDSTACK-1645.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java ea89eda
> api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 6719b8f
> server/src/com/cloud/vm/UserVmManagerImpl.java 88086ce
>
> Diff: https://reviews.apache.org/r/9892/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. deploy an instance.
> 2. stop the instance.
> 3. change service offering.
> a) to higher resources -- if resources are not within account resource limits, CS throws resourceAllocationException else service offering successfully changed.
> b) to lower resources -- success.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUODSTACK-1645 : Resources limit is not validated with
update compute offering [ Instances are updated to higher CPU/Memory
resources though there are no resources available @ account/domain]
Posted by Min Chen <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9892/#review17916
-----------------------------------------------------------
Ship it!
Ship It!
- Min Chen
On March 13, 2013, 7:36 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9892/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 7:36 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.
>
>
> Description
> -------
>
> CLOUDSTACK-1645 : Resources limit is not validated with update compute offering [ Instances are updated to higher CPU/Memory resources though there are no resources available @ account/domain]
>
>
> This addresses bug CLOUDSTACK-1645.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java ea89eda
> api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 6719b8f
> server/src/com/cloud/vm/UserVmManagerImpl.java 88086ce
>
> Diff: https://reviews.apache.org/r/9892/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. deploy an instance.
> 2. stop the instance.
> 3. change service offering.
> a) to higher resources -- if resources are not within account resource limits, CS throws resourceAllocationException else service offering successfully changed.
> b) to lower resources -- success.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>