You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/07/12 20:29:48 UTC

[GitHub] [hbase] xcangCRM commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

xcangCRM commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303138175
 
 

 ##########
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
 ##########
 @@ -1445,6 +1445,9 @@
       "hbase.util.default.lossycounting.errorrate";
   public static final String NOT_IMPLEMENTED = "Not implemented";
 
+  // Default Snapshot TTL - 30 days (good enough?)
+  public static final long DEFAULT_SNAPSHOT_TTL = 24 * 3600 * 30;
 
 Review comment:
   So, what's the usage of the default TTL? If user doesn't specify TTL, should we just use default Snapshot API to take snapshot and keep it forever? If user specifies TTL, we use the value user set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services