You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "shchun (via GitHub)" <gi...@apache.org> on 2026/10/24 13:55:45 UTC

[PR] test(chart-list): cover custom tag filtering [superset]

shchun opened a new pull request, #45695:
URL: https://github.com/apache/superset/pull/45695

   ### SUMMARY
   
   The previous tests removed system tags, such as `type:chart`, before rendering TagsList. As a result, they could still pass if the actual ChartList filtering regressed and started displaying system tags. This change passes unfiltered tag data through ChartList and checks the rendered result so that the tests can catch that regression.
   
   The new cases cover numeric custom tags, legacy custom tags, tags without a type, system-only tags, empty or missing tags, and truncation after filtering. TagsList retains unit coverage for sorting and truncation. Application code is unchanged.
   
   AI assistance: I used Codex to help implement, review, and validate the tests, and to translate my explanation into English.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable: tests only; no UI changes.
   
   ### TESTING INSTRUCTIONS
   
   From `superset-frontend`, run:
   
   ```bash
   npm run test -- --runInBand src/pages/ChartList/ChartList.listview.test.tsx src/components/TagsList/TagsList.test.tsx
   ```
   
   - Both suites passed: 30 tests total, using Node 24 in a Linux Docker container.
   - All applicable pre-commit hooks passed, including frontend type checking, against the two staged test files in a Linux validation copy verified to match the working branch. Referenced core package declarations were built first.
   - Regression check: in the isolated validation copy, temporarily replacing ChartList's `tags.filter(...)` with `tags` caused four of the six new cases to fail. The production source was restored, and both suites passed again.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [x] Required feature flags: `TAGGING_SYSTEM`, enabled in the test mocks.
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(chart-list): cover custom tag filtering [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #45695:
URL: https://github.com/apache/superset/pull/45695#issuecomment-6457723954

   @shchun code looks good but you have a failing CI. Can you take a look? Your branch may just need a rebase/merge master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(chart-list): cover custom tag filtering [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45695:
URL: https://github.com/apache/superset/pull/45695#issuecomment-6462233705

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45695?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 65.26%. Comparing base ([`e97d7ca`](https://app.codecov.io/gh/apache/superset/commit/e97d7cac645c817e9b9c0daebabcbb9b0802cde9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8cba05e`](https://app.codecov.io/gh/apache/superset/commit/8cba05e3af3214cef1da583c8b761655fb69d58b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #45695   +/-   ##
   =======================================
     Coverage   65.26%   65.26%           
   =======================================
     Files        3068     3068           
     Lines      204990   204990           
     Branches    48174    48174           
   =======================================
   + Hits       133788   133791    +3     
   + Misses      68154    68151    -3     
     Partials     3048     3048           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/45695/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/45695/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.76% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45695?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(chart-list): cover custom tag filtering [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45695:
URL: https://github.com/apache/superset/pull/45695#issuecomment-6385128154

   ## CodeAnt PR Risk: Low Risk
   
   - The PR appears safe to merge; no actionable issues were identified in the review.
   
   **Assessed commit:** `613edbc78bc6`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(chart-list): cover custom tag filtering [superset]

Posted by "shchun (via GitHub)" <gi...@apache.org>.
shchun commented on PR #45695:
URL: https://github.com/apache/superset/pull/45695#issuecomment-6459737062

   Rebased onto the latest master. All 52 related tests and pre-commit checks pass locally. The workflows appear to be awaiting approval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org