You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/07/28 22:06:44 UTC

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] enapps-enorman opened a new pull request #6: SLING-10684 add integration tests to verify

enapps-enorman opened a new pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6


   For verifying the SLING-10677 fix
   
   Requires https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] raducotescu commented on a change in pull request #6: SLING-10684 add integration tests to verify

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6#discussion_r678893378



##########
File path: pom.xml
##########
@@ -336,13 +336,13 @@ Require-Capability: osgi.extender;filter:="(&(osgi.extender=sling.scripting)(ver
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.runtime</artifactId>
-            <version>1.2.4-1.4.0</version>
+            <version>1.2.5-1.4.0-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.compiler</artifactId>
-            <version>1.2.12-1.4.0</version>
+            <version>1.2.13-1.4.0-SNAPSHOT</version>

Review comment:
       Ah, that's for https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/8, but it was not clear from this PR, nor from https://issues.apache.org/jira/browse/SLING-10677.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] enapps-enorman merged pull request #6: SLING-10684 add integration tests to verify

Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] enapps-enorman commented on a change in pull request #6: SLING-10684 add integration tests to verify

Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6#discussion_r679434629



##########
File path: pom.xml
##########
@@ -336,13 +336,13 @@ Require-Capability: osgi.extender;filter:="(&(osgi.extender=sling.scripting)(ver
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.runtime</artifactId>
-            <version>1.2.4-1.4.0</version>
+            <version>1.2.5-1.4.0-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.compiler</artifactId>
-            <version>1.2.12-1.4.0</version>
+            <version>1.2.13-1.4.0-SNAPSHOT</version>

Review comment:
       > I don't think you need to bump the compiler.
   
   You are probably right.  None of the tests here are directly impacted by https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/8 
   
   The testing for SLING-10682 was done with local unit tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] enapps-enorman commented on pull request #6: SLING-10684 add integration tests to verify

Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6#issuecomment-888655768


   NOTE: the ci build fails because of new SNAPSHOT dependencies that are not available there yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] raducotescu commented on a change in pull request #6: SLING-10684 add integration tests to verify

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6#discussion_r678890297



##########
File path: pom.xml
##########
@@ -336,13 +336,13 @@ Require-Capability: osgi.extender;filter:="(&(osgi.extender=sling.scripting)(ver
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.runtime</artifactId>
-            <version>1.2.4-1.4.0</version>
+            <version>1.2.5-1.4.0-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.sling</groupId>
             <artifactId>org.apache.sling.scripting.sightly.compiler</artifactId>
-            <version>1.2.12-1.4.0</version>
+            <version>1.2.13-1.4.0-SNAPSHOT</version>

Review comment:
       I don't think you need to bump the compiler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-sightly-testing] sonarcloud[bot] commented on pull request #6: SLING-10684 add integration tests to verify

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/6#issuecomment-897190489


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-testing&pullRequest=6&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org