[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

["Trustin Lee (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12361582 ] 

Trustin Lee commented on DIRMINA-68:
------------------------------------

Thank you for your high-quality contribution.  It looks good!  But I want to point out some issues with this filter:

* Some people wants to use dynamic reconnect delay.  For example, the delay could be increased if connection attempt fails multiple times in a row.
* This filter won't work if the *first* connection attempt fails as you noticed.  I think we need a cleaner way to provide reconnection.

For example we could provide IoConnector.setReconnectPolicy( ReconnectPolicy ) method.  ReconnectPolicy will look like this:

public abstract class ReconnectPolicy {
    public static ReconnectPolicy NEVER = ..;

    public static ReconnectPolicy getInstance(int maxAttempts, int reconnectDelay);

    public abstract long nextReconnectTime( int nAttempts, Throwable reconnectCause );
}

WDYT?

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira