You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/23 13:50:11 UTC
[GitHub] [buildstream-plugins] gtristan opened a new pull request, #33: Encode hard coded version in one location instead of two
gtristan opened a new pull request, #33:
URL: https://github.com/apache/buildstream-plugins/pull/33
This could be improved to go full fledged versioneer like BuildStream, but
for now instead of hard coding the version in setup.py and doc/source/conf.py,
just encode it in the toplevel __init__.py and derive it from both locations.
* src/buildstream_plugins/__init__.py: Set __version__ here
* setup.py: Import __version__ and use it for invoking setuptools
* doc/source/conf.py: Import __version__ and use it to set the docs version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #33: Encode hard coded version in one location instead of two
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #33:
URL: https://github.com/apache/buildstream-plugins/pull/33#issuecomment-1224291135
> looks fine, assuming that setting Sphinx `version` and `release` to the same thing is not a big deal
It's the same thing we do in BuildStream (except we go full on versioneer to do it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan merged pull request #33: Encode hard coded version in one location instead of two
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #33:
URL: https://github.com/apache/buildstream-plugins/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org