You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/10/18 18:33:23 UTC
[PR] ci(r): Refactor CI configuration [arrow-adbc]
paleolimbot opened a new pull request, #1210:
URL: https://github.com/apache/arrow-adbc/pull/1210
This PR moves R workflows into their own file since they don't depend on any other jobs. It also adds an r-nightly job that checks some of the more obscure things (e.g., older R versions, valgrind, rchk).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(r): Refactor CI configuration [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1210:
URL: https://github.com/apache/arrow-adbc/pull/1210#issuecomment-1772732242
105 checks might be a bit excessive...they are all short, but 50% of the runtime of each of them is just setting up R at this point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(r): Refactor CI configuration [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1210:
URL: https://github.com/apache/arrow-adbc/pull/1210#issuecomment-1772734425
Oh, right, but many of them are weekly and not on every PR. That's better then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(r): Refactor CI configuration [arrow-adbc]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #1210:
URL: https://github.com/apache/arrow-adbc/pull/1210#discussion_r1366407295
##########
.github/workflows/r-extended.yml:
##########
@@ -0,0 +1,200 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: R (extended)
+
+on:
+ # Run weekly
+ schedule:
+ - cron: '5 0 * * 0'
+
+ pull_request:
+ branches:
+ - main
+ paths:
+ - ".github/workflows/r-extended.yml"
+
+permissions:
+ contents: read
+
+jobs:
+
+ # Runs R CMD check in the same way CRAN might (i.e., without any test databases,
+ # using oldrel, release, devel.
+ check-for-cran:
+ name: "cran - ${{ matrix.pkg }} / ${{ matrix.os }} / R-${{ matrix.rversion}}"
+ runs-on: ${{ matrix.os }}-latest
+
+ strategy:
+ matrix:
+ rversion: [oldrel, release, devel]
+ os: [macOS, windows, ubuntu]
+ pkg: [adbcdrivermanager, adbcsqlite, adbcpostgresql, adbcflightsql, adbcsnowflake]
+ fail-fast: false
+
+ env:
+ GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
Any secrets should not be set globally as envvars (neither workflow nor job wide) and only set in the step they are used. That way potentially compromised actions can't grab them. Not essential here as the permissions are set to read only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(r): Refactor CI configuration [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #1210:
URL: https://github.com/apache/arrow-adbc/pull/1210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(r): Refactor CI configuration [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #1210:
URL: https://github.com/apache/arrow-adbc/pull/1210#discussion_r1366973391
##########
.github/workflows/r-extended.yml:
##########
@@ -0,0 +1,200 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: R (extended)
+
+on:
+ # Run weekly
+ schedule:
+ - cron: '5 0 * * 0'
+
+ pull_request:
+ branches:
+ - main
+ paths:
+ - ".github/workflows/r-extended.yml"
+
+permissions:
+ contents: read
+
+jobs:
+
+ # Runs R CMD check in the same way CRAN might (i.e., without any test databases,
+ # using oldrel, release, devel.
+ check-for-cran:
+ name: "cran - ${{ matrix.pkg }} / ${{ matrix.os }} / R-${{ matrix.rversion}}"
+ runs-on: ${{ matrix.os }}-latest
+
+ strategy:
+ matrix:
+ rversion: [oldrel, release, devel]
+ os: [macOS, windows, ubuntu]
+ pkg: [adbcdrivermanager, adbcsqlite, adbcpostgresql, adbcflightsql, adbcsnowflake]
+ fail-fast: false
+
+ env:
+ GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
That must have been a hangover from some earlier workflow (I think maybe pak needs it for setup-r-dependencies but we don't install anything from GitHub at the moment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(r): Refactor CI configuration [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1210:
URL: https://github.com/apache/arrow-adbc/pull/1210#issuecomment-1772839248
Ok, I think I got it down to 5 checks that run on every PR, which should catch most things from changes outside the r/ directory that would break the packages. It's true that setting up R has higher overhead than setting up Python...I'm happy to re-workshop these if that becomes a problem (but since most of them just run weekly I don't think it will come up).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org