[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #7: SLING-9420 - Create required configurations for o.a.s.installer.factory.packages

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/7#discussion_r419599618



##########
File path: src/main/provisioning/repoinit.txt
##########
@@ -71,6 +71,13 @@
         allow	rep:write	on /apps/sling/install
     end
 
+    # content-package installer
+    create service user sling-package-install
+
+    set ACL for sling-package-install
+        allow	jcr:all     on	/

Review comment:
       seems a bit too broad, especially as right now the service user is only used to upload packages: https://github.com/apache/sling-org-apache-sling-installer-factory-packages/blob/84b0f9243e2c7cc733762e8ce199549632eaf9a2/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L146. The actual installation still takes an admin session (https://github.com/apache/sling-org-apache-sling-installer-factory-packages/blob/84b0f9243e2c7cc733762e8ce199549632eaf9a2/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L262), this should be fixes though as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org