[GitHub] merlimat commented on issue #1206: Allow derived implementations of RackawareEnsemblePlacementPolicy

[GitBox <gi...@apache.org>]

merlimat commented on issue #1206: Allow derived implementations of RackawareEnsemblePlacementPolicy
URL: https://github.com/apache/bookkeeper/pull/1206#issuecomment-368673180
 
 
   > Can we add some javadoc to state that this class is supposed to be extended? 
   
   This class is not necessarily supposed to be extended: it already provides rack-aware feature out of the box. In our use case we just wanted to add more functionality to support bookie isolation in different groups.
   
   The class is already public, though the constructors are package-protected. I don't think that it changes a lot on what it's considered public API. In many other implementation classes we have public constructors.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services