You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2013/12/04 23:10:14 UTC
Review Request 16019: QPID-5307: Fix bug in windows NullAuthenticator,
not setting realm on user IDs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16019/
-----------------------------------------------------------
Review request for qpid and Steve Huston.
Bugs: QPID-5307
https://issues.apache.org/jira/browse/QPID-5307
Repository: qpid
Description
-------
QPID-5307: Fix bug in windows NullAuthenticator, not setting realm on user IDs.
ACL tests were failing because the windows NullAuthenticator does not add the @QPID realm to the user ID.
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1546628
Diff: https://reviews.apache.org/r/16019/diff/
Testing
-------
Thanks,
Alan Conway
Re: Review Request 16019: QPID-5307: Fix bug in windows NullAuthenticator,
not setting realm on user IDs.
Posted by Alan Conway <ac...@redhat.com>.
> On Dec. 4, 2013, 11:32 p.m., Chug Rolke wrote:
> > This also resolves https://issues.apache.org/jira/browse/QPID-3981
> >
Great thanks, will commit that separately.
- Alan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16019/#review29773
-----------------------------------------------------------
On Dec. 4, 2013, 10:10 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16019/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 10:10 p.m.)
>
>
> Review request for qpid and Steve Huston.
>
>
> Bugs: QPID-5307
> https://issues.apache.org/jira/browse/QPID-5307
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5307: Fix bug in windows NullAuthenticator, not setting realm on user IDs.
>
> ACL tests were failing because the windows NullAuthenticator does not add the @QPID realm to the user ID.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1546628
>
> Diff: https://reviews.apache.org/r/16019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request 16019: QPID-5307: Fix bug in windows NullAuthenticator,
not setting realm on user IDs.
Posted by Chug Rolke <cr...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16019/#review29773
-----------------------------------------------------------
Ship it!
This also resolves https://issues.apache.org/jira/browse/QPID-3981
- Chug Rolke
On Dec. 4, 2013, 10:10 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16019/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 10:10 p.m.)
>
>
> Review request for qpid and Steve Huston.
>
>
> Bugs: QPID-5307
> https://issues.apache.org/jira/browse/QPID-5307
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5307: Fix bug in windows NullAuthenticator, not setting realm on user IDs.
>
> ACL tests were failing because the windows NullAuthenticator does not add the @QPID realm to the user ID.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1546628
>
> Diff: https://reviews.apache.org/r/16019/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>