[jira] [Commented] (HIVE-26843) Filter all dependency module descriptors from shaded jars.

["Chris Nauroth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-26843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647661#comment-17647661 ] 

Chris Nauroth commented on HIVE-26843:
--------------------------------------

Thank you, [~zabetak]!

> Filter all dependency module descriptors from shaded jars.
> ----------------------------------------------------------
>
>                 Key: HIVE-26843
>                 URL: https://issues.apache.org/jira/browse/HIVE-26843
>             Project: Hive
>          Issue Type: Improvement
>          Components: Beeline, Hive, JDBC
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> HIVE-26813 upgraded HikariCP from 2.6.1 to 4.0.3. During review of [PR#3839|https://github.com/apache/hive/pull/3839], we discussed the need to omit its module descriptor (module-info.class) from shaded jars. However, it turns out there are also existing instances of module-info.class files from other dependencies like Jackson and Log4J leaking into the shaded jars. We can update the shading filters with wildcards to exclude these and also make it future-proof against any other dependencies that start including a module descriptor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)