[jira] [Updated] (SOLR-9119) ValueSourceParser.addParser should be private

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-9119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-9119:
---------------------------
    Attachment: SOLR-9119.patch

patch for master making the apis for modifying the "standard" list of value source parsers private.

On branch_6x we can leave these public, but mark them deprecated - that would at least help prevent mistakes like tests/plugins shipping with solr (and initially developed against master) from trying to muck with this stuff (which is how i discovered this in the first place)

> ValueSourceParser.addParser should be private
> ---------------------------------------------
>
>                 Key: SOLR-9119
>                 URL: https://issues.apache.org/jira/browse/SOLR-9119
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: SOLR-9119.patch
>
>
> these static helper methods should only be used by the static init code in the same class for registering the default list of valuesource parsers.  Plugin writters should never use these -- the fact that they are public is dangerous and leaves us open to bugs if/when plugin writers (or tests) try to use them and may affect other cores/collections in the same JVM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org