You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/11/01 21:47:39 UTC
[Impala-ASF-CR] IMPALA-7790: Skip some Kudu tests if use hybrid clocklse
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11850
Change subject: IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false
......................................................................
IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false
Since IMPALA-6812, we've run many of our tests against Kudu at the
READ_AT_SNAPSHOT scan level, which ensures consistent results. This
scan level is only supported if Kudu is run with the flag
--use_hybrid_clock=true (which is the default).
This patch uses the Kudu master webui to detect when use_hybrid_clock
is false and skips these tests.
Follow up work will address allowing these tests to run regardless of
the value of the flag.
Testing:
- Ran a full exhaustive build with use_hybrid_clock=false set in the
minicluster.
Change-Id: If752cf326ec8321e9405d6b4ff82a3410767b8b4
---
M bin/impala-config.sh
M tests/common/kudu_test_suite.py
M tests/common/skip.py
M tests/custom_cluster/test_kudu.py
M tests/metadata/test_ddl.py
M tests/query_test/test_kudu.py
6 files changed, 50 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/11850/1
--
To view, visit http://gerrit.cloudera.org:8080/11850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If752cf326ec8321e9405d6b4ff82a3410767b8b4
Gerrit-Change-Number: 11850
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7790: Skip some Kudu tests if use hybrid clocklse
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11850 )
Change subject: IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1255/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If752cf326ec8321e9405d6b4ff82a3410767b8b4
Gerrit-Change-Number: 11850
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Nov 2018 22:29:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7790: Skip some Kudu tests if use hybrid clocklse
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/11850 )
Change subject: IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false
......................................................................
Abandoned
submitted wrong thing
--
To view, visit http://gerrit.cloudera.org:8080/11850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: If752cf326ec8321e9405d6b4ff82a3410767b8b4
Gerrit-Change-Number: 11850
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7790: Skip some Kudu tests if use hybrid clocklse
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11850 )
Change subject: IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11850/1/tests/common/kudu_test_suite.py
File tests/common/kudu_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/11850/1/tests/common/kudu_test_suite.py@44
PS1, Line 44: def get_kudu_master_webpage(page_name):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/11850/1/tests/common/kudu_test_suite.py@56
PS1, Line 56: def get_kudu_master_flag(flag):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/11850/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/11850/1/tests/query_test/test_kudu.py@382
PS1, Line 382: @
flake8: E303 too many blank lines (2)
--
To view, visit http://gerrit.cloudera.org:8080/11850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If752cf326ec8321e9405d6b4ff82a3410767b8b4
Gerrit-Change-Number: 11850
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Nov 2018 21:49:02 +0000
Gerrit-HasComments: Yes