You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "mehrdadh (via GitHub)" <gi...@apache.org> on 2023/01/23 22:24:09 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #13829: [docker][microTVM]Fix Zephyr 0.15.2 SDK installation and separate Zephyr python environment
mehrdadh opened a new pull request, #13829:
URL: https://github.com/apache/tvm/pull/13829
This PR fixes the SDK installation and separates SDK installation from ZephyrProject installation.
Also it separates the Zephyr python environment to 3.8 which is the required version and it is different than tvm virtual env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #13829: [docker][microTVM]Fix Zephyr 0.15.2 SDK installation and separate Zephyr python environment
Posted by "driazati (via GitHub)" <gi...@apache.org>.
driazati commented on code in PR #13829:
URL: https://github.com/apache/tvm/pull/13829#discussion_r1085959980
##########
docker/Dockerfile.ci_cortexm:
##########
@@ -76,12 +76,15 @@ COPY install/ubuntu_install_sccache.sh /install/ubuntu_install_sccache.sh
RUN bash /install/ubuntu_install_sccache.sh
ENV PATH /opt/sccache:$PATH
-# Zephyr SDK deps
+# Zephyr Project
COPY install/ubuntu_install_zephyr.sh /install/ubuntu_install_zephyr.sh
COPY install/ubuntu_init_zephyr_project.sh /install/ubuntu_init_zephyr_project.sh
-COPY install/ubuntu_install_zephyr_sdk.sh /install/ubuntu_install_zephyr_sdk.sh
RUN bash /install/ubuntu_install_zephyr.sh
ENV ZEPHYR_BASE=/opt/zephyrproject/zephyr
+
+#Zephyr SDK
Review Comment:
```suggestion
# Zephyr SDK
```
##########
docker/install/ubuntu_install_zephyr.sh:
##########
@@ -58,10 +78,4 @@ chmod -R o+w ${ZEPHYR_PROJECT_PATH}
mkdir zephyr/.cache
chmod o+rwx zephyr/.cache
-pip3 install -r /opt/zephyrproject/zephyr/scripts/requirements.txt
-
-# the requirements above overwrite junintparser with an older version, but it is not
-# used so overwrite it again with the correct version
-pip3 install junitparser==2.4.2
Review Comment:
Isn't this just using the system Python with `python_cmd` here? This should still re-install junitparser since that was a hack to get a specific version working in CI which didn't agree with zephyr's requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #13829: [docker][microTVM]Fix Zephyr 0.15.2 SDK installation and separate Zephyr python environment
Posted by "areusch (via GitHub)" <gi...@apache.org>.
areusch commented on code in PR #13829:
URL: https://github.com/apache/tvm/pull/13829#discussion_r1085992666
##########
docker/install/ubuntu_install_zephyr.sh:
##########
@@ -58,10 +78,4 @@ chmod -R o+w ${ZEPHYR_PROJECT_PATH}
mkdir zephyr/.cache
chmod o+rwx zephyr/.cache
-pip3 install -r /opt/zephyrproject/zephyr/scripts/requirements.txt
-
-# the requirements above overwrite junintparser with an older version, but it is not
-# used so overwrite it again with the correct version
-pip3 install junitparser==2.4.2
Review Comment:
i think i might have removed pip3 to stop ppl from installing stuff outside the tvm venv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #13829: [docker][microTVM]Fix Zephyr 0.15.2 SDK installation and separate Zephyr python environment
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh merged PR #13829:
URL: https://github.com/apache/tvm/pull/13829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13829: [docker][microTVM]Fix Zephyr 0.15.2 SDK installation and separate Zephyr python environment
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #13829:
URL: https://github.com/apache/tvm/pull/13829#issuecomment-1401089190
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @alanmacd, @gromero, @leandron, @mkatanbaf <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org