You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 17:03:20 UTC
[GitHub] [arrow] pykello opened a new pull request, #13380: Fix LZ4 support build for VS 2019 & 2022
pykello opened a new pull request, #13380:
URL: https://github.com/apache/arrow/pull/13380
This fixes building arrow/parquet with LZ4 support on Windows for Visual Studio 2019 & 2022.
Changes:
1. PlatformToolset=v140 requires Windows SDK 8, which is not normally installed with VS 2019 or 2022. I changed it to use the toolset available for the current build system, which will be v142 or v143 in recent VS versions.
2. The LZ4 library project doesn't have "Relwithdebinfo" configuration, so when trying to build arrow/parquet with relwithdebinfo, it fails. I added a condition to use Release for LZ4 when the parent arrow/parquet is being built using with relwithdebinfo.
With above changes, I could create arrow/parquet dlls with LZ4 support to be used internally at Microsoft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13380: Fix LZ4 support build for VS 2019 & 2022
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13380:
URL: https://github.com/apache/arrow/pull/13380#issuecomment-1155474275
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pykello closed pull request #13380: [C++] Fix LZ4 support build for VS 2019 & 2022
Posted by GitBox <gi...@apache.org>.
pykello closed pull request #13380: [C++] Fix LZ4 support build for VS 2019 & 2022
URL: https://github.com/apache/arrow/pull/13380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13380: [C++] Fix LZ4 support build for VS 2019 & 2022
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13380:
URL: https://github.com/apache/arrow/pull/13380#issuecomment-1208302396
@kou Since the PR author is responsive, I don't know if you would like to take this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #13380: Fix LZ4 support build for VS 2019 & 2022
Posted by GitBox <gi...@apache.org>.
kou commented on PR #13380:
URL: https://github.com/apache/arrow/pull/13380#issuecomment-1155640018
LZ4 provides `.sln` for Visual Studio 2017 https://github.com/lz4/lz4/tree/dev/build/VS2017 and CMake files https://github.com/lz4/lz4/tree/dev/build/cmake . How about using CMake files like Zstandard https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2319 when CMake is 3.7 or later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13380: [C++] Fix LZ4 support build for VS 2019 & 2022
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13380:
URL: https://github.com/apache/arrow/pull/13380#issuecomment-1156503777
@pykello Could you perhaps open a JIRA ticket for this? See https://arrow.apache.org/docs/developers/bug_reports.html for how to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pykello commented on pull request #13380: [C++] Fix LZ4 support build for VS 2019 & 2022
Posted by GitBox <gi...@apache.org>.
pykello commented on PR #13380:
URL: https://github.com/apache/arrow/pull/13380#issuecomment-1208357718
@pitrou sorry for not being responsive. Closing so I reopen it properly in future when I have more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #13380: [C++] Fix LZ4 support build for VS 2019 & 2022
Posted by GitBox <gi...@apache.org>.
kou commented on PR #13380:
URL: https://github.com/apache/arrow/pull/13380#issuecomment-1208629988
No problem. I've opened a JIRA issue for this: ARROW-17348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org