Re: [PR] UI support for the scaleSystemVm API [cloudstack]

["Damans227 (via GitHub)" <gi...@apache.org>]

Damans227 commented on code in PR #13321:
URL: https://github.com/apache/cloudstack/pull/13321#discussion_r3624819917


##########
ui/src/config/section/infra/systemVms.js:
##########
@@ -100,14 +100,15 @@ export default {
       label: 'label.change.service.offering',
       message: 'message.confirm.scale.up.system.vm',
       dataView: true,
-      show: (record) => { return record.state === 'Running' && record.hypervisor === 'VMware' || record.state === 'Stopped' },
+      show: (record) => { return record.state === 'Running' && (record.hypervisor === 'VMware' || record.hypervisor === 'KVM') || record.state === 'Stopped' },

Review Comment:
   Nit: mixing `&&`/`||` without parens around the whole expression is a bit hard to scan, even though the added parens around the hypervisor check are correct. Wrapping the full condition in parens would make the intent clearer at a glance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org