[GitHub] spark pull request #17680: [SPARK-20364][SQL] Support Parquet predicate push...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17680#discussion_r116572835
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala ---
    @@ -536,4 +537,53 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex
           // scalastyle:on nonascii
         }
       }
    +
    +  test("SPARK-20364: Predicate pushdown for columns with a '.' in them") {
    +    import testImplicits._
    +
    +    Seq(true, false).foreach { vectorized =>
    +      withSQLConf(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key -> vectorized.toString) {
    +        withTempPath { path =>
    +          Seq(Some(1), None).toDF("col.dots").write.parquet(path.getAbsolutePath)
    +          assert(spark.read.parquet(path.getAbsolutePath).where("`col.dots` > 0").count() == 1)
    +        }
    --- End diff --
    
    Instead of duplicating the codes, please write a helper function. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org